Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
Comment: | Remove assert() statements based on the counter-factual proposition that 0 is not a valid cursor number. |
---|---|
Downloads: | Tarball | ZIP archive |
Timelines: | family | ancestors | descendants | both | window-functions |
Files: | files | file ages | folders |
SHA3-256: |
c7b336181aac6785a515f275c0f50ad4 |
User & Date: | dan 2019-03-21 13:51:09.569 |
Context
2019-03-22
| ||
13:56 | Fix a problem with a window function in a correlated sub-query where at least one reference to the outer SELECT appears in a FROM clause sub-select. (Closed-Leaf check-in: 9aca86f983 user: dan tags: window-functions) | |
2019-03-21
| ||
13:51 | Remove assert() statements based on the counter-factual proposition that 0 is not a valid cursor number. (check-in: c7b336181a user: dan tags: window-functions) | |
2019-03-19
| ||
19:39 | Add further tests to window8.test. (check-in: ec7e224f50 user: dan tags: window-functions) | |
Changes
Changes to src/window.c.
︙ | ︙ | |||
1258 1259 1260 1261 1262 1263 1264 | sqlite3VdbeAddOp2(v, OP_OpenEphemeral, pWin->csrApp, 2); sqlite3VdbeAppendP4(v, pKeyInfo, P4_KEYINFO); sqlite3VdbeAddOp2(v, OP_Integer, 0, pWin->regApp+1); } else if( p->zName==nth_valueName || p->zName==first_valueName ){ /* Allocate two registers at pWin->regApp. These will be used to ** store the start and end index of the current frame. */ | < < | 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 | sqlite3VdbeAddOp2(v, OP_OpenEphemeral, pWin->csrApp, 2); sqlite3VdbeAppendP4(v, pKeyInfo, P4_KEYINFO); sqlite3VdbeAddOp2(v, OP_Integer, 0, pWin->regApp+1); } else if( p->zName==nth_valueName || p->zName==first_valueName ){ /* Allocate two registers at pWin->regApp. These will be used to ** store the start and end index of the current frame. */ pWin->regApp = pParse->nMem+1; pWin->csrApp = pParse->nTab++; pParse->nMem += 2; sqlite3VdbeAddOp2(v, OP_OpenDup, pWin->csrApp, pMWin->iEphCsr); } else if( p->zName==leadName || p->zName==lagName ){ pWin->csrApp = pParse->nTab++; sqlite3VdbeAddOp2(v, OP_OpenDup, pWin->csrApp, pMWin->iEphCsr); } } } #define WINDOW_STARTING_INT 0 |
︙ | ︙ |
Changes to test/window1.test.
︙ | ︙ | |||
1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 | do_ordercount_test 23.6 { SELECT sum(c) OVER (ORDER BY b+1 ROWS UNBOUNDED PRECEDING), sum(c) OVER (ORDER BY b+2 RANGE UNBOUNDED PRECEDING), sum(c) OVER (ORDER BY b+3 GROUPS UNBOUNDED PRECEDING) FROM t5 } 3 finish_test | > > > > > > > > > | 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 | do_ordercount_test 23.6 { SELECT sum(c) OVER (ORDER BY b+1 ROWS UNBOUNDED PRECEDING), sum(c) OVER (ORDER BY b+2 RANGE UNBOUNDED PRECEDING), sum(c) OVER (ORDER BY b+3 GROUPS UNBOUNDED PRECEDING) FROM t5 } 3 do_execsql_test 24.1 { SELECT sum(44) OVER () } {44} do_execsql_test 24.2 { SELECT lead(44) OVER () } {{}} finish_test |